Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gxify fuse lib, update it, might fix OSX with new fuzz and move lots of stuff to gx #3414

Closed
wants to merge 10 commits into from

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Nov 23, 2016

I've tested it on my Arch Linux 4.7.6 machine.
It might solve more issues we are seeing with FUSE.

Resolves #3471

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu Kubuxu added the status/in-progress In progress label Nov 23, 2016
@Kubuxu Kubuxu force-pushed the feat/gx-fuzz branch 5 times, most recently from 7150bfd to 1f0d74b Compare November 23, 2016 15:16
@Kubuxu Kubuxu changed the title Gxify fuse lib, update it, might fix OSX with new fuzz Gxify fuse lib, update it, might fix OSX with new fuzz and move lots of stuff to gx Nov 23, 2016
@Kubuxu Kubuxu added the need/review Needs a review label Nov 24, 2016
@whyrusleeping
Copy link
Member

i wonder why the js-ipfs-api tests are still failing...

@whyrusleeping
Copy link
Member

This resolves #3410 right?

@Kubuxu
Copy link
Member Author

Kubuxu commented Nov 28, 2016

#3413 resolves #3410 directly but Victor tested it out it turns out that on OSX fuse 3 doesn't work so I hope that this fixes it.

@victorb
Copy link
Member

victorb commented Nov 28, 2016

Ok, I've tested this as well, on OSX 10.11.4 and osx-fuse 3.5.3 and it's working fine now!

@whyrusleeping
Copy link
Member

@Kubuxu can you rebase this one?

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 2, 2016

Rebased

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@whyrusleeping
Copy link
Member

@Kubuxu This is such a large diff that it makes me nervous to put it in 0.4.5. Thoughts?

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 5, 2016

I think I will fixup the messages with FUSE on OSX and let's leave it for next release. I feel like it could delay this one too much.

@Kubuxu Kubuxu added status/ready Ready to be worked and removed status/in-progress In progress labels Dec 5, 2016
@Kubuxu Kubuxu self-assigned this Dec 5, 2016
@Kubuxu Kubuxu mentioned this pull request Dec 14, 2016
@Kubuxu Kubuxu added this to the ipfs 0.4.6 milestone Dec 14, 2016
@whyrusleeping
Copy link
Member

@Kubuxu update here? Since we want to release 0.4.6 very soon, how about we get this in 0.4.7 in the next week or so?

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.7, ipfs 0.4.6 Feb 14, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 14, 2017

I think right now it might be easier to do it from grounds up...

Rebasing is hell

@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 26, 2017

Closing this, I'll do it part by part.

@Kubuxu Kubuxu closed this Feb 26, 2017
@Kubuxu Kubuxu removed the status/ready Ready to be worked label Feb 26, 2017
@Kubuxu Kubuxu deleted the feat/gx-fuzz branch February 27, 2017 20:37
@Kubuxu Kubuxu removed this from the Ipfs 0.4.7 milestone Feb 27, 2017
@momack2 momack2 added this to Needs Review in ipfs/go-ipfs May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
No open projects
ipfs/go-ipfs
Needs Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants