Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps:go-multiaddr) update to b90678896b52c #46

Merged

Conversation

btc
Copy link
Contributor

@btc btc commented Sep 11, 2014

No description provided.

procedure is to execute
```
cd my/github.com/jbenet/go-multiaddr
git pull
cd my/github.com/jbenet/go-ipfs
godep update github.com/jbenet/go-multiaddr
```
@btc btc force-pushed the deps/go-multiaddr-b90678896b52c3e5a4c8176805c6facc3fe3eb82 branch from 65f55ad to 7f39299 Compare September 11, 2014 18:16
@whyrusleeping
Copy link
Member

So, youre following some sort of standard for your naming conventions of branches, issues, and pull requests. Is there some sort of spec i can read through? I kinda like it.

@btc
Copy link
Contributor Author

btc commented Sep 11, 2014

The style you're seeing is an amalgamation of git flow and the angular js conventions. No hard and fast rules.

Angular JS commit message conventions (PR/issue names, commit messages):
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit

Git Flow (branch naming):
http://nvie.com/posts/a-successful-git-branching-model/

Design Goals:

  • provide information about (1) the type of change (2) which subsystems are concerned (3) description of change
  • avoid naming collisions
  • reduce conceptual overhead (complexity) by helping us to pattern match and use "fast twitch" thinking when reviewing code

@jbenet
Copy link
Member

jbenet commented Sep 11, 2014

Awesome, thanks @perfmode

jbenet added a commit that referenced this pull request Sep 11, 2014
…a4c8176805c6facc3fe3eb82

chore(deps:go-multiaddr) update to b90678896b52c
@jbenet jbenet merged commit dbc3a05 into master Sep 11, 2014
@btc btc deleted the deps/go-multiaddr-b90678896b52c3e5a4c8176805c6facc3fe3eb82 branch September 11, 2014 18:44
ribasushi pushed a commit that referenced this pull request Jul 4, 2021
add env vars for logging to file and syslog
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
plugins: don't omit empty config values
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants