Assert output types #514
Merged
Assert output types #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so much type-system circumvention. i've little context from commands to usefully CR this -- should i just merge it @mappum? |
|
It's definitely not go idiomatic, but it works. Yeah, it's solid and mergeable. |
|
This was reverted (per #516 (comment)) -- let's fix + try again |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
object statthat causes it to error when run locally (not on the daemon). This is because commands must return pointer values (sadly there's no way around it with our crazyinterface{}magic in the commands package).I added a check for this that will panic if a developer makes their command return a non-pointer to prevent the mistake from happening in the future.