Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin: list recursive by default #5559

Closed
wants to merge 1 commit into from

Conversation

overbool
Copy link
Contributor

@overbool overbool commented Oct 3, 2018

Fixes: #5556

License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com

License: MIT
Signed-off-by: Overbool <overbool.xu@gmail.com>
@overbool overbool requested a review from Kubuxu as a code owner October 3, 2018 23:53
@eingenito eingenito added the status/in-progress In progress label Oct 4, 2018
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work, but as noted in #5556, we probably want to include recursive+direct pins by default. Handling multiple options with , is an option (ipfs init --profile does that), another option is getting ipfs/go-ipfs-cmds#135 (strings option) in and using that

@Stebalien
Copy link
Member

Closing so we can go with the recursive,direct solution.

@Stebalien Stebalien closed this Feb 1, 2019
@ghost ghost removed the status/in-progress In progress label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants