Fetch big files by "stream" CID. #7897
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petar
commented
Feb 3, 2021
petar
commented
- generate a "chunking manifest" of files added to ipfs, to be used for inserting the files into a "big file store" (or another name)
- compute the stream cid of the added file
…or inserting the file into a big file datastore
gammazero
force-pushed
the
hack/bigfiles
branch
from
e2032e1
to
4579f27
Compare
…f the big file store (now placeholder)
…t cycle and used in go-ipfs
gammazero
reviewed
Feb 19, 2021
| return nil | ||
| default: | ||
| return err2 | ||
| } |
There was a problem hiding this comment.
nit: maybe simplify and replace the switch { ... } with:
if err2 != nil {
if err2 == blockstore.ErrNotFound {
return err1
}
return err2
}
return nil| chunks, err := b.GetBigBlock(c) | ||
| if err == ds.ErrNotFound { | ||
| return 0, blockstore.ErrNotFound | ||
| } |
There was a problem hiding this comment.
This if err == ds.ErrNoFound { is not needed. Just use the check below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.