Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dag test fixtures for go-ipld-prime codecs #8257

Merged
merged 4 commits into from Jul 21, 2021

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 15, 2021

Pending ipld/go-ipld-prime#202 and ipld/go-ipld-prime#203

  • I've massaged one of the main fixtures so that it's pre-sorted according to DAG-CBOR rules since go-ipld-prime as yet doesn't apply any sorting, I didn't want to treat that as a blocker for this PR but it may have to be treated as a blocker for release (similar change to Sort map entries marshalling dag-json ipld/go-ipld-prime#203, but there's deep background here ... cans of worms).
  • dag get doesn't print a newline now, which I think is the right behaviour since it can now do any codec and newlines are going to be a problem for the stricter binary formats than dag-json, so I've adapted the fixtures.
  • The proper DAG-PB Data / Links changes show up here and are now correct, as are the new (proper) rules for showing bytes with DAG-JSON.
  • There's a change near the bottom for dag stat, this comes from go-ipld-cbor doing always-64-bit integers, but we're now doing always-smallest-possible now across all our codecs, so go-ipld-cbor is the odd one out (old and new JS codecs do this, and spec says it).

@rvagg rvagg requested a review from willscott July 15, 2021 11:32
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for digging through these!

@rvagg rvagg force-pushed the rvagg/feat/dag-put-ipld-prime branch from 5961cd1 to 9f5af56 Compare July 21, 2021 03:44
@rvagg
Copy link
Member Author

rvagg commented Jul 21, 2021

Now using go-ipld-prime master with DAG-JSON sorting and no whitespace. Still having trouble with the full sharness run in Circle but will merge this into the feat/dag-put-ipld-prime when CI is done if it doesn't throw up anything new. The sharness problems can be worked on in that branch.

@rvagg rvagg merged commit 9f43c7b into feat/dag-put-ipld-prime Jul 21, 2021
@rvagg rvagg deleted the rvagg/feat/dag-put-ipld-prime branch July 21, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants