fix: remove some deprecated calls #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/deprecated
branch
from
f56edde
to
b4c105b
Compare
Stebalien
commented
Jul 23, 2021
core/corehttp/logs.go
Outdated
| @@ -50,7 +50,7 @@ func LogOption() ServeOption { | |||
| w.WriteHeader(200) | |||
| wnf, errs := newWriteErrNotifier(w) | |||
| lwriter.WriterGroup.AddWriter(wnf) | |||
| log.Event(n.Context(), "log API client connected") //nolint deprecated | |||
| log.Info("log API client connected") | |||
There was a problem hiding this comment.
Apparently we still need this...
grep "log API client connected" log_out
fails.
I thought we were sending events here now...
marten-seemann
approved these changes
Jul 24, 2021
|
@Stebalien : will you update the logging or adjust the test so this passes? |
Stebalien
force-pushed
the
fix/deprecated
branch
from
b4c105b
to
2138798
Compare
|
I've reversed the change for now. |
|
CI is broken due to ipfs/go-ipfs-api#248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.