feat(cmds): add version check command #8839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add some tests to this? |
I'll need some pointers on how to set up a local network to test this, otherwise the test will become much more work than the feature itself. |
lidel
force-pushed
the
schomatis/feat/notify-outdated-version
branch
from
0af8837
to
8077843
Compare
lidel
force-pushed
the
schomatis/feat/notify-outdated-version
branch
from
8077843
to
f0a214b
Compare
lidel
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Triage note:
- rebased
- this PR was created before we had
ipfs routingand custom routing, perhaps there is a better way to get peerbook now - it is ad-hoc command, which is fine, but we need something that runs works out-of-the box, like we did in feat: warn users who are falling behind reprovides #9886
|
Continued in #10438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ipfs version checkcommand to check running version against our DHT peers and report if a (configurable) fraction of them are running a newer (stable) version. (Manually tested decreasing the localCurrentVersionNumber, not sure of a simple way to test this locally in sharness.)This is the first step toward #6487. Once this lands we can incorporate it as a periodic command in a running daemon if we want.