refactor: rename to kubo #8958
Merged
refactor: rename to kubo #8958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
lidel
force-pushed
the
chore/rename-to-banana
branch
2 times, most recently
from
fce44e1
to
9149d6e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
lidel
force-pushed
the
chore/rename-to-banana
branch
from
9149d6e
to
970b922
Compare
This comment was marked as resolved.
This comment was marked as resolved.
guseggert
approved these changes
May 10, 2022
|
i love it ❤️ |
|
@lidel might work
|
achingbrain
reviewed
May 27, 2022
lidel
force-pushed
the
chore/rename-to-banana
branch
from
2be521e
to
4aaadfc
Compare
lidel
changed the title
lidel
changed the title
|
Pushed 6086a70 with minimal refactor that allows our Docker image publishing machine to work and publish the same image under both names: $ ./bin/get-docker-tags.sh $(date -u +%F) 88d88158c master
ipfs/kubo:master-2022-06-21-88d8815
ipfs/go-ipfs:master-2022-06-21-88d8815
ipfs/kubo:master-latest
ipfs/go-ipfs:master-latest(For now we keep 👉 @aschmahmann @BigLep @guseggert I think this is ready for review – the sooner we merge this and rename the repo, the more time we have to fix things that WILL break before July. 👉 |
lidel
force-pushed
the
chore/rename-to-banana
branch
from
6086a70
to
4891bb4
Compare
some things like third party package names, docker image etc need to stay as go-ipfs for now
This ensures we keep publishing the same image under both names:
$ ./bin/get-docker-tags.sh $(date -u +%F) 88d8815 master ...chore/rename-to-banana
ipfs/kubo:master-2022-06-21-88d8815
ipfs/go-ipfs:master-2022-06-21-88d8815
ipfs/kubo:master-latest
ipfs/go-ipfs:master-latest
lidel
force-pushed
the
chore/rename-to-banana
branch
from
6276bf9
to
3417ed4
Compare
This was referenced Jul 6, 2022
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
refactor: rename to kubo see: ipfs/kubo#8959 This commit was moved from ipfs/kubo@d82dec3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why rename?
Please see ipfs/ipfs#470 and #8959
Why
kubo?Please see #8959 (it was picked by both devs and community).
Rationale for this PR
Renaming to "banana" until a better name comes along.
In all seriousness, this PR aims to identify the minimal surface we need to change before July, given the limited bandwidth IPFS Stewards have.
TODO
go-ipfsandfkubonames (done: refactor: rename to kubo #8958 (comment))Part of #8959 – see it for the full context