config: change default config dir name to .ipfs #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM. Before merging to master, we'll need to write a migration. I've the beginnings of the migration stuff in #950. Not sure what the best way to work on, review, and merge code that will go into one repo version upgrade, but perhaps:
A key thing to consider here is that minimizing the number of migrations is good for users. If things go wrong, reasoning about one atomic change is easier than many. (at least this is my intuition) |
|
I'm assigning @chriscool to this, if I'm wrong, please fix. |
Closed
This changes .go-ipfs to .ipfs everywhere. And by the way this defines a DefaultPathName const for this name. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
whyrusleeping
force-pushed
the
change_config_dir
branch
from
2a7cb92
to
52633c1
Compare
|
rebased this so i can work on merging it into migrations (#950) |
|
This was pulled in in #950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes .go-ipfs to .ipfs everywhere.
And by the way this defines a DefaultPathName const
for this name.
This should fix issue #970 (move to using ~/.ipfs).
fixes #970
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org