Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cookie prompt to the bottom #341

Closed
lidel opened this issue Dec 6, 2022 · 4 comments · Fixed by #353
Closed

Move cookie prompt to the bottom #341

lidel opened this issue Dec 6, 2022 · 4 comments · Fixed by #353
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/perf Performance

Comments

@lidel
Copy link
Member

lidel commented Dec 6, 2022

The cookie prompt introduced in #309 is pushing page contents down, causing reflow when user submits the choice.

Would it be ok to move it down, and have it fixed to the bottom of viewport? This way we dont have reflow:

2022-12-06_13-25

@lidel lidel added the need/triage Needs initial labeling and prioritization label Dec 6, 2022
@SgtPooki
Copy link
Member

SgtPooki commented Dec 7, 2022

I'm fine with moving to the bottom as a fixed element in the viewport.

@SgtPooki SgtPooki added P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked topic/perf Performance and removed need/triage Needs initial labeling and prioritization labels Dec 7, 2022
@davidfcopozo
Copy link

Hello, I'll be more than happy to contribute to this. Can it be assigned to me?

@juliaxbow
Copy link
Collaborator

This conversation is strongly related to #340 where we're discussing a floating, fixed cookie button in the bottom left corner. If we do this, suggest that we not have any banner and instead shift to a modal box. OK with a bottom banner while that's being discussed, though, to fix the reflow issue!

@davidfcopozo
Copy link

I just read the conversation and I like the new modal, it's a way better approach than the current banner, but if it's not an immediate solution I think that moving it to the bottom in the meantime is a good idea since the current banner at the top is not even fixed, and users can easily lose sight of if while scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/perf Performance
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants