Use New Routing V1 #17
Conversation
| github.com/libp2p/go-libp2p-resource-manager v0.5.1 | ||
| github.com/libp2p/go-libp2p-routing-helpers v0.2.3 | ||
| github.com/urfave/cli/v2 v2.8.1 | ||
| github.com/ipfs/boxo v0.13.2-0.20231009073559-45c797e0ccea |
There was a problem hiding this comment.
TODO: use a released boxo when available
There was a problem hiding this comment.
Yeah, the reason I'm not using latest is because client.Client is not exposed 🥲
| log.Printf("Listening on http://0.0.0.0:%d", port) | ||
| log.Printf("Delegated Routing API on http://127.0.0.1:%d/routing/v1", port) |
There was a problem hiding this comment.
Might be fine, but also a little confusing since routing/v1 is on 127.0.0.1 and all other interfaces too.
main.go
Outdated
| &cli.StringSliceFlag{ | ||
| Name: "content-endpoints", |
There was a problem hiding this comment.
I'm not sure how much we need these yet. Fine to keep them if you'd like, but also reasonable to pull them until we know more specifically what we (or other users) might need.
There's a bunch of added configurability in kubo and some we could plausibly want that isn't there yet either. (e.g. DHT enabled vs disabled, cid.contact enabled vs disabled, if we do an IPNS Put should it fail if it doesn't Put to all of the routers/are some fallbacks, etc.).
|
Merging for now. Following up on #18 once Boxo is released. |
Also added some more options to allow users to add more servers to proxy too (per routing type).