-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added commands for Windows download #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @yooakim!
Unblock-File ./$zipFileName | ||
Expand-Archive -Path ./$zipFileName -DestinationPath $env:LOCALAPPDATA\ipinfo -Force | ||
Remove-Item -Path ./$zipFileName | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to wrap this script into something similar to the MacOS / Ubuntu/Debian scripts? So that someone could do the windows version of this and have the script automatically run in almost a 1-liner:
# this would download a script containing all the above steps, run the script, and then delete itself.
$ curl -Ls https://github.com/ipinfo/cli/releases/download/ipinfo-1.1.0/macos.sh | sh
FYI the existing scripts are found in this folder and we include them in the final releases here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just put the statements in a file with extension .ps1 and then it could be handled in the same way as the curl example above. You can use PowerShell simething like this:
Invoke-Expression (New-Object System.Net.WebClient).DownloadString('https://github.com/ipinfo/cli/releases/download/ipinfo-1.1.0/setup-win.ps1')
This line would download the script and then launch it. You can see an example how it is used over at scoop.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, thank you!
We ended up already adding scripts @ #80 so we don't actually need this anymore. Let us know though how those scripts work for you. Example: https://github.com/ipinfo/cli#windows-powershell
@rm-Umar in case you have Windows setup, can you check to see if this script works, and maybe to try to take over this PR? |
Added commands for downloading the ipinfo cli tool using PowerShell.