Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added commands for Windows download #24

Closed
wants to merge 2 commits into from

Conversation

yooakim
Copy link

@yooakim yooakim commented May 4, 2021

Added commands for downloading the ipinfo cli tool using PowerShell.

Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yooakim!

Unblock-File ./$zipFileName
Expand-Archive -Path ./$zipFileName -DestinationPath $env:LOCALAPPDATA\ipinfo -Force
Remove-Item -Path ./$zipFileName
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to wrap this script into something similar to the MacOS / Ubuntu/Debian scripts? So that someone could do the windows version of this and have the script automatically run in almost a 1-liner:

# this would download a script containing all the above steps, run the script, and then delete itself.
$ curl -Ls https://github.com/ipinfo/cli/releases/download/ipinfo-1.1.0/macos.sh | sh

FYI the existing scripts are found in this folder and we include them in the final releases here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just put the statements in a file with extension .ps1 and then it could be handled in the same way as the curl example above. You can use PowerShell simething like this:

Invoke-Expression (New-Object System.Net.WebClient).DownloadString('https://github.com/ipinfo/cli/releases/download/ipinfo-1.1.0/setup-win.ps1')

This line would download the script and then launch it. You can see an example how it is used over at scoop.sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thank you!

We ended up already adding scripts @ #80 so we don't actually need this anymore. Let us know though how those scripts work for you. Example: https://github.com/ipinfo/cli#windows-powershell

README.md Outdated Show resolved Hide resolved
@UmanShahzad
Copy link
Contributor

@rm-Umar in case you have Windows setup, can you check to see if this script works, and maybe to try to take over this PR?

@rm-Umar
Copy link
Contributor

rm-Umar commented Nov 26, 2021

Added the scripts for PowerShell in #80 PR. Thanks for your contribution @yooakim

@rm-Umar rm-Umar closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants