Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Readme #47

Closed
wants to merge 2 commits into from
Closed

Update the Readme #47

wants to merge 2 commits into from

Conversation

paul-hph
Copy link

No description provided.

Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also just consider using something else for caching in the underlying PHP library.

@rm-Umar

@rm-Umar
Copy link
Contributor

rm-Umar commented Jan 13, 2023

We can also just consider using something else for caching in the underlying PHP library.

@rm-Umar

Yes, we can, I just checked, and sabre/cache is still on ^1.0 for some reason.
https://github.com/sabre-io/cache/blob/1d80519ebbb125b06fe0661bb01b9f304839b842/composer.json#L18

@UmanShahzad
Copy link
Contributor

Let's do that then in our php lib, gotta find some new cache library.

@Samuel-Gill
Copy link

@UmanShahzad What should be our goal moving forward ? I guess we have following options:

  • Update the PHP library to use psr/simple-cache 3 , this requires updating whole codebase, cache usage, run tests, documentation, release and versioning.
  • Ask the user to rm composer.lock and composer install again. As psr/simple-cache 3 which comes with latest version also supports previous versions.

@UmanShahzad
Copy link
Contributor

@Samuel-Gill as discussed let's use some new cache lib in the PHP SDK, publish that change, then update its version here. Should fix all the issues.

@abu-usama
Copy link
Contributor

abu-usama commented Aug 1, 2023

We decided to go ahead with symfony/cache in our php library. (See this change here). The current latest version of this library, 2.6.0, incorporates that change.
Closing this PR due to irrelevancy.
cc: @UmanShahzad

@abu-usama abu-usama closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants