-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding symfony cache #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of trivial issues here that could be causing it. Just mismatching interfaces and stuff.
@UmanShahzad all tests has passed. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samuel-Gill have we shown this to work with the test cases? And do we have valid test cases for testing the cache, like repeating the same lookup a few times?
Yes I have run tests present in tests/DefaultCacheTest.php . It all passed. If any new test is required which is not covering our use-case, you can let me know and I'll create it. |
@Samuel-Gill I don't know - you gotta check yourself and see if the tests cover the changes made here well enough! |
Also CI is failing. |
Yes I have checked, we are covering the changes made here.
|
Fixed. |
In this PR, I am adding symfony cache.