support batch requests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmanShahzad
reviewed
Sep 13, 2022
There was a problem hiding this comment.
So one of the key features of batch requests in our SDKs is that we allow inputting an arbitrary number of URLs, not just the max of 1000 which is what the API limits you to.
The SDKs do internal chunking of batches into batches of 1k, and concurrently execute all of them if the language allows. See https://github.com/ipinfo/go/blob/master/ipinfo/batch.go for the golang version or https://github.com/ipinfo/node/blob/master/src/ipinfoWrapper.ts#L359-L485 for the nodejs version.
UmanShahzad
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function
batch_requests(url_array, api_token)to support batch requests.