forked from Automattic/node-canvas
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from Automattic:master #36
Open
pull
wants to merge
75
commits into
iplabs:master
Choose a base branch
from
Automattic:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatly improves font matching accuracy Fixes #1572
* feat: add ESM support * docs: updated CHANGELOG * refactor: destructure once Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> * fix: use `exports.[name] = value` instead Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
While testing the solution for a local build, I got the next output: ```sh Package pixman-1 was not found in the pkg-config search path. Perhaps you should add the directory containing `pixman-1.pc' to the PKG_CONFIG_PATH environment variable No package 'pixman-1' found gyp: Call to 'pkg-config pixman-1 --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp ``` After updating the command to the following: `brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman`, I was able to generate a succesful build. ```sh brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman; cd /node_modules/canva && npx node-gyp rebuild; ```
`rgb()` and `rgba()` are supposed to have identical grammar and behavior: https://www.w3.org/TR/css-color-4/#rgb-functions. Fixes #2029
v9 dropped Node.js v10 support.
The WPT tests for this now pass. See issue for test content; I think it makes more sense to land the WPT tests than to copy individual ones into the node-canvas tests. Fixes #2055
Borrowed from Chromium instead of reinventing the wheel. Firefox's is similar: https://searchfox.org/mozilla-central/source/gfx/2d/PathHelpers.h#127 Fixes #1736 Fixes #1808
* Adds deregisterAllFonts to the typescript declaration file * updates changelog with deregisterAllFonts type fix
https://developer.chrome.com/blog/canvas2d/#round-rect WPT tests: 326 passing (1s) 9 pending 129 failing (down from 179)
This bug goes back 10 years to the original implementation. Fixes #1909
this makes the lineTo benchmark (lineTo executes a very small number of operations, so it mostly measures the js<->C++ barrier) run about 50% faster
this is possibly a hot path, and avoiding the C++ string helps a little bit
f3184ba introduced a use-after- free bug. Pango does not copy the string when you use the _static version of pango_font_description_set_family. Font selection was not working for me at all.
* Drop support for older versions of Node.js * Install python setuptools on macOS * Temporarily disable tests on Windows + Node.js 20
* fix the wrong type of setTransform * Update CHANGELOG.md
The following updates are performed: * update actions/checkout to v4 * update actions/setup-node to v4
* added deregisterAllFonts to readme * Update Readme.md
64ed3d8
to
ff0f2ab
Compare
changed OS X to macOS
Added in #2229, this is a C++20 feature. For now we're on C++17 (by way of Node.js v18).
Prebuilds are built using the prebuilds branch. These files are unused and confusing.
-rc1 never really existed, but I created the tag and don't want to delete it in case someone is installing from github.
* Fix leading whitespace in color string issue * Add parsing support for floating point numbers in rbg function * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )