Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from Automattic:master #36

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 31, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jan 31, 2022
chearon and others added 27 commits February 24, 2022 20:12
greatly improves font matching accuracy

Fixes #1572
Use latest setup-node and pin to Windows 2019. Windows 2022 needs dealing with later.
* feat: add ESM support

* docs: updated CHANGELOG

* refactor: destructure once

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

* fix: use `exports.[name] = value` instead

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
the problem was exposed by #1987, but was always there

fixes #2041
While testing the solution for a local build, I got the next output:
```sh
Package pixman-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `pixman-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'pixman-1' found
gyp: Call to 'pkg-config pixman-1 --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
```

After updating the command to the following: `brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman`, I was able to generate a succesful build.

```sh
brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman;
cd /node_modules/canva && npx node-gyp rebuild;
```
`rgb()` and `rgba()` are supposed to have identical grammar and behavior: https://www.w3.org/TR/css-color-4/#rgb-functions.

Fixes #2029
v9 dropped Node.js v10 support.
The WPT tests for this now pass. See issue for test content; I think it makes more sense to land the WPT tests than to copy individual ones into the node-canvas tests.

Fixes #2055
Borrowed from Chromium instead of reinventing the wheel. Firefox's is similar: https://searchfox.org/mozilla-central/source/gfx/2d/PathHelpers.h#127

Fixes #1736
Fixes #1808
* Adds deregisterAllFonts to the typescript declaration file

* updates changelog with deregisterAllFonts type fix
https://developer.chrome.com/blog/canvas2d/#round-rect

WPT tests:
    326 passing (1s)
    9 pending
    129 failing (down from 179)
This bug goes back 10 years to the original implementation.

Fixes #1909
chearon and others added 10 commits September 19, 2023 11:03
this makes the lineTo benchmark (lineTo executes a very small
number of operations, so it mostly measures the js<->C++ barrier)
run about 50% faster
this is possibly a hot path, and avoiding the C++ string helps a
little bit
f3184ba introduced a use-after-
free bug. Pango does not copy the string when you use the _static
version of pango_font_description_set_family. Font selection was
not working for me at all.
* Drop support for older versions of Node.js

* Install python setuptools on macOS

* Temporarily disable tests on Windows + Node.js 20
* fix the wrong type of setTransform

* Update CHANGELOG.md
The following updates are performed:
* update actions/checkout to v4
* update actions/setup-node to v4
* added deregisterAllFonts to readme

* Update Readme.md
zbjornson and others added 4 commits December 28, 2023 17:10
changed OS X to macOS
Added in #2229, this is a C++20 feature. For now we're on C++17 (by way of Node.js v18).
Prebuilds are built using the prebuilds branch. These files are unused and confusing.
-rc1 never really existed, but I created the tag and don't want to delete it in case someone is installing from github.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet