Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading animation while CAR is loading #85

Closed
lidel opened this issue Apr 14, 2022 · 1 comment
Closed

Add loading animation while CAR is loading #85

lidel opened this issue Apr 14, 2022 · 1 comment
Assignees
@alvin-reyes
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Collaborator

lidel commented Apr 14, 2022

Problem

Loading a bigger CAR takes a dozen(s) of seconds while car is imported – nothing happens, looks like something is broken.

How to reproduce:

Test with CAR thats >20MB, eg:

$ ipfs dag export bafybeiednzu62vskme5wpoj4bjjikeg3xovfpp4t7vxk5ty2jxdi4mv4bu > webui.car

Proposed fix

Display the same loading animation as we already do when a CID is not found in local repo and is being looked up on DHT:

https://explore.ipld.io/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2s (fake CID that will never load)

cc @alvin-reyes
@lidel lidel added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Apr 14, 2022
@alvin-reyes alvin-reyes mentioned this issue Apr 15, 2022
Merged
@alvin-reyes alvin-reyes self-assigned this Apr 15, 2022
@lidel
Copy link
Collaborator Author

lidel commented Apr 25, 2022

Done in ipfs/ipld-explorer-components#318 / #87

@lidel lidel closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvin-reyes alvin-reyes

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @alvin-reyes