Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CAR Upload loader #318

Merged
merged 14 commits into from
Apr 25, 2022
Merged

feat: CAR Upload loader #318

merged 14 commits into from
Apr 25, 2022

Conversation

alvin-reyes
Copy link
Collaborator

@alvin-reyes alvin-reyes commented Apr 15, 2022 •
edited

Changes

This is an extension to the previous PR to support CAR import.

  • Added new properties - uploadIcon and spinnerIcon

Related/Resolves

ipld/explore.ipld.io#85

@alvin-reyes alvin-reyes requested a review from lidel April 15, 2022 22:10
@alvin-reyes alvin-reyes self-assigned this Apr 16, 2022
@alvin-reyes alvin-reyes changed the title feat: CAR Upload Loading-Spinner Animation feat: CAR Upload loader Apr 16, 2022
lidel
lidel previously requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this PR seems to be missing the spinner – mind adding it to this PR?
  • animated spinner should be visible only after a file is selected

@alvin-reyes
Copy link
Collaborator Author

  • this PR seems to be missing the spinner – mind adding it to this PR?
  • animated spinner should be visible only after a file is selected

The image? It's on the ipld-explorer but I'm thinking now that maybe better to move the images to the ipld-explorer-component.

@alvin-reyes alvin-reyes requested a review from lidel April 22, 2022 14:34
@alvin-reyes alvin-reyes mentioned this pull request Apr 22, 2022
Merged
@alvin-reyes alvin-reyes dismissed lidel’s stale review April 22, 2022 15:16

Added the changes based on the review / feedbacks.

lidel
lidel approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

(I muted "inactive" state a bit so users don't try to click on it)

@lidel lidel merged commit cf30c14 into master Apr 25, 2022
@lidel lidel deleted the car-loader branch April 25, 2022 12:58
github-actions bot pushed a commit that referenced this pull request Apr 25, 2022
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
8d88810 
## [2.2.0](v2.1.1...v2.2.0) (2022-04-25)

### Features

* CAR Upload loader  ([#318](#318)) ([cf30c14](cf30c14))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lidel lidel mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@alvin-reyes alvin-reyes

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvin-reyes @lidel