This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
Updates to dependencies #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the gen/main.go systems to new codegen; they compile, but I have not exercised them. IIUC, reapplying codegen in this package may require additional manual intervention afterwards. My goal in this diff is to move forward the version of go-ipld-prime so that transitive dependencies on passing through this library can be happier; it is not necessary for me to reapply codegen today in order to accomplish this.
This is mostly applying renames to methods changed upstream. Roughly: sed s/NodeStyle/NodePrototype/g sed s/IsUndefined/IsAbsent/g sed s/LookupIndex/LookupByIndex/g sed s/LookupString/LookupByString/g sed s/LookupSegment/LookupBySegment/g sed 's/Lookup(/LookupByNode(/g' sed 's/Style(/Prototype(/g' sed 's/ipld\.Undef/ipld\.Absent/g' ... and thereafter I fixed a few style/prototype references manually, because there were two syntaxes used to access them, inconsistently, and I figured I'd leave this slightly better than I found it. I didn't attempt to update variables (typically, "ns"->"np"). Some cleanup on that in the future might feel desirable.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 23.22% 23.22%
=======================================
Files 7 7
Lines 797 797
=======================================
Hits 185 185
Misses 596 596
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating some updates to go-ipld-prime interfaces and exported symbols through this repo.
One commit for each of the version jumps: one for v0.4.0, and one for v0.5.0. See commit messages for details.
Externally apparently semantics should be more or less unchanged.