Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node/basic: add Chooser #198

Merged
merged 1 commit into from
Jun 19, 2021
Merged

node/basic: add Chooser #198

merged 1 commit into from
Jun 19, 2021

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Jun 18, 2021

(see commit message)

@mvdan mvdan requested a review from warpfork June 18, 2021 09:09
@mvdan
Copy link
Contributor Author

mvdan commented Jun 18, 2021

FYI @ribasushi since this can avoid a bit of verbosity in your IPLD end-to-end code sample, once it lands in master soon.

warpfork
warpfork approved these changes Jun 18, 2021
View reviewed changes
Copy link
Collaborator

@warpfork warpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@mvdan mvdan merged commit e798ae8 into ipld:master Jun 19, 2021
@mvdan mvdan deleted the basicnode-chooser branch June 21, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@warpfork warpfork warpfork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdan @willscott @warpfork