This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
skip tests failing on windows machines #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3-bot
force-pushed
the
web3-bot/sync
branch
from
f3a6275
to
947b7bd
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
from
947b7bd
to
6d08b03
Compare
galargh
force-pushed
the
fix/windows-tests
branch
from
1069b19
to
acebd27
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
from
6d08b03
to
ec0ddaa
Compare
galargh
force-pushed
the
fix/windows-tests
branch
from
acebd27
to
4676425
Compare
|
@mvdan I'm following up on #2 (comment). This will allow us to merge the unified CI sync. |
mvdan
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Sounds good!
My two cents: it probably isn't worth trying to fix these skips until upstream go-ipld-prime passes with its tests on Windows. I started that work a few months back with help from @marten-seemann, but didn't wrap it up. I'll take a look this week.
web3-bot
added a commit
that referenced
this pull request
Jan 17, 2022
* run go mod tidy * add .github/workflows/automerge.yml * add .github/workflows/go-test.yml * add .github/workflows/go-check.yml * add .github/workflows/releaser.yml * add .github/workflows/release-check.yml * add .github/workflows/tagpush.yml * skip tests failing on windows machines (#7) Co-authored-by: web3-bot <web3-bot@users.noreply.github.com> Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestion from #2 (comment)
Here's a CI result of go-test workflow from my account: https://github.com/galargh/go-ipldtool/actions/runs/1476026469
I have also created an issue to track progress: #6
I'll be happy to work on it further and find a proper resolution.