Skip to content

fix embedded bridged responses handling #142

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

dfrycki
Copy link
Contributor

@dfrycki dfrycki commented Jun 25, 2019

fixes #141

vmauery
vmauery previously approved these changes Jun 26, 2019
@vmauery
Copy link
Member

vmauery commented Jun 26, 2019

I helped @dfrycki debug this issue on an OpenBMC platform. When the memmove happens, it was not correctly resetting the offset and shadow offset into that buffer, causing out-of-bounds memory references for encapsulated responses.

@AlexanderAmelkin
Copy link
Contributor

@dfrycki, @vmauery, have you checked it on non-OpenBMC stacks? I don't have any systems with bridging to verify it myself.

@vmauery
Copy link
Member

vmauery commented Jun 27, 2019

I have tested it on two generations of prior Intel systems, both of which are different IPMI stacks (AMI-based and proprietary). From what we can understand from the behavior of those is that they split the response into two packets and skip this broken path. OpenBMC sends the response all in one packet and hits this issue where the offsets are incorrect.

But now either path works.

Resolves ipmitool#141

Signed-off-by: Dawid Frycki <dawid.frycki@intel.com>
@AlexanderAmelkin AlexanderAmelkin merged commit 2ee7aca into ipmitool:master Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect handling of embedded bridged responses
3 participants