Rpmbuildfix #179
Rpmbuildfix #179
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please either add new commits to the same branch or interactively rebase to master and change each commit as needed and then force-push to the same branch. Your changes will automatically appear here. Please see https://github.com/ipmitool/ipmitool/wiki/How-to-contribute#2-contribute-the-changes |
control/ipmitool.spec.in
Outdated
| @@ -1,10 +1,13 @@ | |||
| %define debug_package %{nil} | |||
|
|
|||
| Name: ipmitool | |||
| Summary: ipmitool - Utility for IPMI control | |||
| Version: @VERSION@ | |||
| Release: @RPM_RELEASE@%{?_distro:.%{_distro}} | |||
| License: BSD | |||
| Group: Utilities | |||
| Packager: Jim Mankovich <jmank@hp.com> | |||
There was a problem hiding this comment.
Well, while we're at it, this spec file is just a template. I don't think it needs to contain the name of Jim because the resulting RPM package will definitely NOT be packaged by him. I think there must be some macro here like those @VERSION@ and @RPM_RELEASE@ above. I just don't know which.
There was a problem hiding this comment.
To make it simple, as the Packager info is not mandatory, I've put a commented example :
#Packager: PackagerName <packager@example.com>
gbuloz
force-pushed
the
rpmbuildfix
branch
3 times, most recently
from
44ff6fe
to
60e6a5c
Compare
The command "make rpm" was failing for the following reasons : - setting the build directory to ./rpmbuild/ instead of default ~/rpmbuild/ was ignored. - errors in the spec file : wrong dates and characters in the changelog, and unpackaged files under misc/* - debug package built even if unneeded but failing to build because of missing requisites. Using "rpmbuild -tb ipmitool-*.tar.gz" instead of 'make rpm" builds under ~/rpmbuild/ but also fails because of the last two reasons. Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>
Simplified target "rpm" of Makefile, and removed rpmrc and rpmmacros to use default settings and those from the spec file such as Distribution that has been changed to "GitHub Build" instead of "Sourceforge Build". Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>
Updated specfile changelog according to the Changelog file Signed-off-by: Gilles Buloz <gilles.buloz@kontron.com>
Patches to fix the broken RPM build process, simplify it, and update the changelog