Skip to content

ipmi_fru.c: Provide missing function declarations #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/ipmi_fru.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ static const char *section_id[4] = {
"Board Section",
"Product Section"
};
/* From lib/ipmi_hpmfwupg.c: */
uint16_t
ipmi_intf_get_max_request_data_size(struct ipmi_intf * intf);

/* From src/plugins/ipmi_intf.c: */
uint16_t
ipmi_intf_get_max_response_data_size(struct ipmi_intf * intf);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These must go to the respective header files, not here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in latest sources I see these functions are already defined in include/ipmitool/ipmi_intf.h after 1724b031 which fixes the problem at hand, so this patch is not needed anymore.


static const char * combined_voltage_desc[] = {
"12 V",
Expand Down