Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync finished notice cancel #20

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix sync finished notice cancel #20

merged 3 commits into from
Apr 17, 2023

Conversation

gammazero
Copy link
Collaborator

  • Fix a possible deadlock when canceling sync finished event notifications with unread notifications.
  • Add unit test to test deadlock fix.
  • Update libp2p to get fixes.

@gammazero gammazero requested a review from masih April 17, 2023 09:06
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (82e2352) 51.23% compared to head (1325746) 51.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   51.23%   51.13%   -0.10%     
==========================================
  Files          56       56              
  Lines        4700     4705       +5     
==========================================
- Hits         2408     2406       -2     
- Misses       2033     2039       +6     
- Partials      259      260       +1     
Impacted Files Coverage Δ
dagsync/subscriber.go 76.76% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero requested a review from ischasny April 17, 2023 15:01
- Fix possible deadlock when cancelling sync finished event notifications with unread notifications.
- Add unit test to test deadlock fix.
- Update libp2p to get fixes.
@github-actions
Copy link

Suggested version: v0.0.7

Comparing to: v0.0.6 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/ipni/go-libipni/find/client/http
## compatible changes
(*DHashClient).FindAsync: added

# diagnostics
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.1.0

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@gammazero gammazero merged commit f4876a4 into main Apr 17, 2023
@gammazero gammazero deleted the fix-event-notice-cancel branch April 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants