Add IPFS Gateway HTTP transport metadata as a well-known multicodec #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Apr 24, 2023
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 51.02% 50.82% -0.21%
==========================================
Files 56 57 +1
Lines 4715 4740 +25
==========================================
+ Hits 2406 2409 +3
- Misses 2049 2070 +21
- Partials 260 261 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Add SDK to aid parsing IPNI metadata that represents IPFS Gateway HTTP transport protocol. Relates to: - multiformats/multicodec#321 Fixes #21
masih
force-pushed
the
masih/ipfs_gateway_http_md
branch
from
ca2d8c4
to
e20eabc
Compare
gammazero
approved these changes
Apr 24, 2023
olizilla
pushed a commit
to web3-storage/ipni
that referenced
this pull request
May 22, 2023
Getting an error still decoding HTTP advertisements in go. Looks like it's due to the fact that HTTP encodes a varint(0) for the payload size -- see ipni/go-libipni#22 (comment) Tagging @willscott and @masih for visibility. I wonder if there is a way we can generate a valid ad and verify against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SDK to aid parsing IPNI metadata that represents IPFS Gateway HTTP transport protocol.
Relates to:
Fixes #21