-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: add a varint 0 for http to match go-libipni #15
Merged
olizilla
merged 1 commit into
storacha:main
from
hannahhoward:fix/http-transport-encoding
May 22, 2023
Merged
fix!: add a varint 0 for http to match go-libipni #15
olizilla
merged 1 commit into
storacha:main
from
hannahhoward:fix/http-transport-encoding
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
fix/http-transport-encoding
branch
from
May 22, 2023 16:33
f4532c4
to
bb19d35
Compare
I've been verifying that the ads generated by this lib are valid as far as |
olizilla
approved these changes
May 22, 2023
olizilla
changed the title
Add a varint 0 for http to match go-libipni
fix!: add a varint 0 for http to match go-libipni
May 22, 2023
olizilla
pushed a commit
that referenced
this pull request
May 22, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.0.0...v3.0.0) (2023-05-22) ### ⚠ BREAKING CHANGES * add a varint 0 for http to match go-libipni ([#15](#15)) ### Bug Fixes * add a varint 0 for http to match go-libipni ([#15](#15)) ([dc59973](dc59973)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
olizilla
added a commit
to elastic-ipfs/publisher-lambda
that referenced
this pull request
May 22, 2023
the http metadata should have a payload length... of zero see: ttps://github.com/storacha/ipni/pull/15 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
added a commit
to elastic-ipfs/publisher-lambda
that referenced
this pull request
May 22, 2023
the http metadata should have a payload length... of zero see: ttps://github.com/storacha/ipni/pull/15 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Deployed to staging, extended provider advert created, and ingested successfully by a local instance of ❯ ./storetheindex admin sync -p Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs --addr "/dns4/staging-ep-ipfs-advertisement.s3.us-west-2.amazonaws.com/tcp/443/https/p2p/Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs"
❯ curl http://localhost:3000/providers/Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs -Ss | jq
{
"AddrInfo": {
"ID": "Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs",
"Addrs": [
"/dns4/elastic-staging.dag.house/tcp/443/wss"
]
},
"LastAdvertisement": {
"/": "baguqeeraxt5ikgt2oy6q4mj7tgpk6itqqpvlfoxxgh7ne52nosaggdnyhn2a"
},
"LastAdvertisementTime": "2023-05-22T21:18:52+01:00",
"Publisher": {
"ID": "Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs",
"Addrs": [
"/dns4/staging-ep-ipfs-advertisement.s3.us-west-2.amazonaws.com/tcp/443/https"
]
},
"IndexCount": 12,
"ExtendedProviders": {
"Providers": [
{
"ID": "Qmc5vg9zuLYvDR1wtYHCaxjBHenfCNautRwCjG3n5v5fbs",
"Addrs": [
"/dns4/elastic-staging.dag.house/tcp/443/wss"
]
},
{
"ID": "QmX5D2SHKfJEjMfUwKAJZtgXhFzmYvA66Hcc9L3ExuVDXs",
"Addrs": [
"/dns4/freeway-staging.dag.haus/tcp/443/https"
]
}
],
"Metadatas": [
"gBI=",
"oBIA"
]
},
"FrozenAt": null
}
base64 encoded metadata for http provider now "oBIA"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an error still decoding HTTP advertisements in go. Looks like it's due to the fact that HTTP encodes a varint(0) for the payload size -- see ipni/go-libipni#22 (comment)
Tagging @willscott and @masih for visibility. I wonder if there is a way we can generate a valid ad and verify against it.