Backfill missing reframe CID timestamps #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CID timestamps might be missing from the CID index / snapshot if the index-provider has been abruptly stopped before the latest snapshot got persisted. In that case - backfill those CIDs with the current timestamp on initialisation so that they match the published ads. This is safe to do. Even if they have expired, they'd still expire just at a later date.
masih
approved these changes
Oct 27, 2022
willscott
approved these changes
Oct 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 44.46% 44.52% +0.06%
==========================================
Files 78 78
Lines 5996 6003 +7
==========================================
+ Hits 2666 2673 +7
Misses 2910 2910
Partials 420 420
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CID timestamps might be missing from the CID index / snapshot if the index-provider has been abruptly stopped before the latest snapshot got persisted. In that case - backfill those CIDs with the current timestamp on initialisation so that they match the published ads. This is safe to do. Even if they have expired, they'd still expire just at a later date.