Disconnect old indexers: Round 2 #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
reviewed
May 30, 2023
| @@ -16,9 +16,6 @@ spec: | |||
| - '--translateNonStreaming' | |||
| # Use service names local to the namespace over HTTP to avoid | |||
| # TLS handshake overhead. | |||
| - '--backends=http://dido-indexer:3000/' | |||
| - '--backends=http://kepa-indexer:3000/' | |||
| - '--backends=http://oden-indexer:3000/' | |||
There was a problem hiding this comment.
It's going to be hard to see effect of disconnecting just one as the data is replicated. I will be keeping an eye on the metrics and revert if things start going wrong again.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
==========================================
- Coverage 51.15% 49.97% -1.19%
==========================================
Files 104 104
Lines 11410 11410
==========================================
- Hits 5837 5702 -135
- Misses 4973 5120 +147
+ Partials 600 588 -12 ☔ View full report in Codecov by Sentry. |
masih
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.