Text: Fixed position bug; added shadow effects #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds shadow effects to Text with options for the color, blur, and offset for both x and y. It also changes two default settings: textAlign to "start" and style to "normal". (Visually, the changes only appear if the browser is set to right-to-left in its language settings.)
Finally fixed a bug in Text I noticed a few days ago by removing the initial translate before the drawing of the text. Because test is drawn using a x and y, the additional translate (unlike sprites) frequently moves the final drawing position to incorrect values. This is much more noticeable when drawing texts within viewports.
ippa
pushed a commit
that referenced
this pull request
Jul 10, 2013
Text: Fixed position bug; added shadow effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Text a great deal more for descriptions of things in the adventure game I'm working on and noticed that the positioning kept being slightly off. After working with it some, I found out the initial translate to its x and y was then pushing the final fillText call off by the difference between the origin and the translate. (The problem is fixed by removing the translate.)
I've also added shadow effects to Text. While any canvas drawing call can use them, they work much better (and have a more general use case) for drawing text than for sprites or even lines.