Minor wording fixes in EOFCREATE spec #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
commented
Apr 24, 2024
| @@ -228,9 +228,10 @@ The following instructions are introduced in EOF code: | |||
| - an unsuccesful execution of initcode results in pushing `0` onto the stack | |||
| - can populate returndata if execution `REVERT`ed | |||
| - a successful execution ends with initcode executing `RETURNCONTRACT{deploy_container_index}(aux_data_offset, aux_data_size)` instruction (see below). After that: | |||
| - load deploy EOF subcontainer at `deploy_container_index` in the container from which `RETURNCONTRACT` is executed | |||
| - load deploy-contract from EOF subcontainer at `deploy_container_index` in the container from which `RETURNCONTRACT` is executed | |||
There was a problem hiding this comment.
"load deploy" doesn't read well
gumb0
commented
Apr 24, 2024
| - concatenate data section with `(aux_data_offset, aux_data_offset + aux_data_size)` memory segment and update data size in the header | ||
| - if updated deploy container size exceeds `MAX_CODE_SIZE` instruction exceptionally aborts | ||
| - let `deployed_code_size` be updated deploy container size |
There was a problem hiding this comment.
deployed_code_size was used in the final step without being defined
axic
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing some feedback for similar spec in ethereum/EIPs#8498