Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vxlan.vlans list is invalid on nodes that have no VLANs #476

Closed
ipspace opened this issue Sep 21, 2022 · 0 comments
Closed

vxlan.vlans list is invalid on nodes that have no VLANs #476

ipspace opened this issue Sep 21, 2022 · 0 comments

Comments

@ipspace
Copy link
Owner

ipspace commented Sep 21, 2022

When a node has no VLANs, the VXLAN module_post_transform hook skips the node without cleaning up the vxlan.vlans list. That might cause some interesting problems in configuration templates that do not check whether the related VLAN exists on the device.

From the "device data model should be consistent" perspective, we should remove vxlan.vlans attribute from nodes that have no vlans attribute.

Discovered by @jbemmel in #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant