Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VyOS and Dell OS10: Support for Unnumbered eBGP #473

Merged
merged 3 commits into from
Sep 21, 2022
Merged

VyOS and Dell OS10: Support for Unnumbered eBGP #473

merged 3 commits into from
Sep 21, 2022

Conversation

ssasso
Copy link
Collaborator

@ssasso ssasso commented Sep 21, 2022

Tested with a modified version of integration/evpn/vxlan-routing-ibgp-over-ebgp-unnumbered.yml

Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions before I'm merging this:

  • Why would you enable RA only on LLA P2P interfaces? It's also needed on LAN IPv6 interfaces, for example to make SLAAC work for attached hosts
  • Looks like OS10 requires explicit 'ipv6 enable' for unnumbered EBGP to work, which means we have to do something about Set 'ipv6: True' on interfaces used for unnumbered IPv6 BGP sessions #460 to make this work with 'tests/integration/bgp/ipv4-unnumbered.yml'. No worries, not your problem, I just need to know there's another platform that needs that flag.

@ssasso
Copy link
Collaborator Author

ssasso commented Sep 21, 2022

  • Why would you enable RA only on LLA P2P interfaces? It's also needed on LAN IPv6 interfaces, for example to make SLAAC work for attached hosts

You are right on this, I'll fix that. I was focused only on the Unnumbered eBGP case forgetting the rest.
I'm setting the PR as WIP for now.

According to Dell's documentation, ipv6 enable is required unless you put any other param regarding ipv6, or if you previously configured the interface with "autoconfig" (basically, it "resets" the IPv6 interface state).
I.e., after setting the nd ra parameters the ipv6 enable became implicitly enabled (and in fact you don't see it in show running-config).

@ssasso ssasso marked this pull request as draft September 21, 2022 15:57
@ipspace
Copy link
Owner

ipspace commented Sep 21, 2022

According to Dell's documentation, ipv6 enable is required unless you put any other param regarding ipv6, or if you previously configured the interface with "autoconfig" (basically, it "resets" the IPv6 interface state). I.e., after setting the nd ra parameters the ipv6 enable became implicitly enabled (and in fact you don't see it in show running-config).

Which still means "it's disabled by default unless you do something to enable it" (and #460 still applies) which is different from Cumulus Linux "IPv6 is enabled on all interfaces, so you get LLA without even asking for it. You're welcome!"

@ssasso
Copy link
Collaborator Author

ssasso commented Sep 21, 2022

Maybe I explained myself in a wrong way.
It is enabled by default, but if you change the state the LLA may be deconfigured. With ipv6 enable you will reset the state.

https://www.dell.com/support/manuals/it-it/dell-emc-smartfabric-os10/smartfabric-os-user-guide-10-5-2-6/enable-or-disable-ipv6?guid=guid-873d7ea2-83a1-4f7b-99f0-a871ac22ef44&lang=en-us

By default:
IPv6 forwarding is enabled on physical Ethernet interfaces, VLANs, and port groups. IPv6 forwarding is disabled only when you enable IPv6 address autoconfiguration on an interface and set it in host mode using the ipv6 address autoconfig command.

If you disable IPv6 and configure a Layer (L2) interface in Layer (L3) mode, IPv6 is not automatically re-enabled on the interface. You must manually re-enable it.

A link-local address automatically generates when you re-enable IPv6 on an interface with the ipv6 enable command.

@ssasso ssasso marked this pull request as ready for review September 21, 2022 16:32
@ipspace ipspace merged commit eca39e3 into ipspace:dev Sep 21, 2022
@ssasso ssasso deleted the vy_dl_unnumbered branch September 21, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants