Change node.runtime to node.clab.runtime, add documentation #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipspace
requested changes
Oct 17, 2022
ipspace
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Move 'runtime' under clab, add default runtime for clab provider (docker) * Update test results Co-authored-by: Jeroen van Bemmel <jeroen.van_bemmel@nokia.com>
ipspace
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Move 'runtime' under clab, add default runtime for clab provider (docker) * Update test results Co-authored-by: Jeroen van Bemmel <jeroen.van_bemmel@nokia.com>
|
Merged and fixed (c1ceb1e) BTW, how many times have I told you to look further than the immediate problem you're solving? runtime has been used for Cumulus VX and your change broke that. To make it worse, that use of runtime was documented, all you'd have to do was to search docs directory for "runtime" (like I did). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #586
Configuration did support multiple runtimes, but feature was undocumented and directly under the node while being a Containerlab specific setting