Skip to content

Commit

Permalink
enable IDN by default
Browse files Browse the repository at this point in the history 
Now that `getaddrinfo()` and `getnameinfo()` are being relied upon for
IDN, we can enable it.
  • Loading branch information
@okias
Pavel Šimerda authored and okias committed Jun 17, 2015
1 parent 37953bf commit f3a4616
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
View file
Expand Up @@ -25,8 +25,8 @@ LDFLAG_RT=-lrt
USE_CAP=yes
# sysfs support (with libsysfs - deprecated) [no|yes|static]
USE_SYSFS=no
# IDN support (experimental) [no|yes|static]
USE_IDN=no
# IDN support [yes|no|static]
USE_IDN=yes

# Do not use getifaddrs [no|yes|static]
WITHOUT_IFADDRS=no
Expand Down

3 comments on commit f3a4616

@nmav
Copy link
Contributor

@nmav nmav commented on f3a4616 Jun 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about this change. Libidn doesn't cope well with malformed input. It may lead to an invalid memory access, causing a crash.
https://bugzilla.redhat.com/show_bug.cgi?id=1197796

@okias
Copy link
Member

@okias okias commented on f3a4616 Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we trigger that? What can we do about it? Port it to libidn2 ?

@nmav
Copy link
Contributor

@nmav nmav commented on f3a4616 Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent a reproducer upstream:
http://permalink.gmane.org/gmane.comp.gnu.libidn.general/573

libidn2 is for a different purpose (following different protocols), so moving to it would make no difference in that aspect. The only real solution would be to fix libidn...

Please sign in to comment.