Skip to content
Permalink
Browse files

enable IDN by default

Now that `getaddrinfo()` and `getnameinfo()` are being relied upon for
IDN, we can enable it.
  • Loading branch information...
Pavel Šimerda authored and okias committed Jun 14, 2015
1 parent 37953bf commit f3a461603ef4fb7512ade3bdb73fe1824e294547
Showing with 2 additions and 2 deletions.
  1. +2 −2 Makefile
@@ -25,8 +25,8 @@ LDFLAG_RT=-lrt
USE_CAP=yes
# sysfs support (with libsysfs - deprecated) [no|yes|static]
USE_SYSFS=no
# IDN support (experimental) [no|yes|static]
USE_IDN=no
# IDN support [yes|no|static]
USE_IDN=yes

# Do not use getifaddrs [no|yes|static]
WITHOUT_IFADDRS=no

3 comments on commit f3a4616

@nmav

This comment has been minimized.

Copy link
Contributor

nmav replied Jun 18, 2015

One comment about this change. Libidn doesn't cope well with malformed input. It may lead to an invalid memory access, causing a crash.
https://bugzilla.redhat.com/show_bug.cgi?id=1197796

@okias

This comment has been minimized.

Copy link
Member

okias replied Jun 19, 2015

Can we trigger that? What can we do about it? Port it to libidn2 ?

@nmav

This comment has been minimized.

Copy link
Contributor

nmav replied Jun 19, 2015

I've sent a reproducer upstream:
http://permalink.gmane.org/gmane.comp.gnu.libidn.general/573

libidn2 is for a different purpose (following different protocols), so moving to it would make no difference in that aspect. The only real solution would be to fix libidn...

Please sign in to comment.
You can’t perform that action at this time.