Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Now that `getaddrinfo()` and `getnameinfo()` are being relied upon for IDN, we can enable it.
- Loading branch information
Now that `getaddrinfo()` and `getnameinfo()` are being relied upon for IDN, we can enable it.
f3a4616
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about this change. Libidn doesn't cope well with malformed input. It may lead to an invalid memory access, causing a crash.
https://bugzilla.redhat.com/show_bug.cgi?id=1197796
f3a4616
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we trigger that? What can we do about it? Port it to libidn2 ?
f3a4616
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent a reproducer upstream:
http://permalink.gmane.org/gmane.comp.gnu.libidn.general/573
libidn2 is for a different purpose (following different protocols), so moving to it would make no difference in that aspect. The only real solution would be to fix libidn...