Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping negative interval #465

Closed
cronolio opened this issue May 15, 2023 · 6 comments · Fixed by #466
Closed

ping negative interval #465

cronolio opened this issue May 15, 2023 · 6 comments · Fixed by #466
Assignees
@pevik
Labels
bug
Milestone
20231222

Comments

@cronolio
Copy link

looks like ping allows to use negative interval like ping -i -0.5 foo.bar. With this ping produce a lot of packages...

example output

ping -ni -0.5 -OD 8.8.8.8
PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.
[1684137776.503110] no answer yet for icmp_seq=1
[1684137776.503132] no answer yet for icmp_seq=2
[1684137776.503141] no answer yet for icmp_seq=3
[1684137776.503150] no answer yet for icmp_seq=4
[1684137776.503158] no answer yet for icmp_seq=5
[1684137776.503167] no answer yet for icmp_seq=6
[1684137776.503175] no answer yet for icmp_seq=7
[1684137776.503209] no answer yet for icmp_seq=8
[1684137776.503218] no answer yet for icmp_seq=9
[1684137776.503226] no answer yet for icmp_seq=10
[1684137776.503235] no answer yet for icmp_seq=11
[1684137776.503243] no answer yet for icmp_seq=12
[1684137776.503252] no answer yet for icmp_seq=13
[1684137776.519204] no answer yet for icmp_seq=13
[1684137776.519265] no answer yet for icmp_seq=14

ping from iputils 20221126
libcap: yes, IDN: yes, NLS: no, error.h: yes, getrandom(): yes, __fpending(): yes

Debian GNU/Linux 12 (bookworm)
Linux <edited> 6.1.0-7-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.20-2 (2023-04-08) x86_64 GNU/Linux
@pevik pevik self-assigned this May 16, 2023
@pevik pevik added the bug label May 16, 2023
@pevik pevik mentioned this issue May 16, 2023
Closed
pevik added a commit to pevik/iputils that referenced this issue May 16, 2023
@pevik
ping: Fix overflow on negative -i
a172db2 
Restore back check for -i <= 0.

Fixes: 918e824 ("ping: add support for sub-second timeouts")
Closes: iputils#465
Signed-off-by: Petr Vorel <pvorel@suse.cz>
@pevik
Copy link
Contributor

pevik commented May 16, 2023 •
edited

@cronolio Would you please provide your real name and your email? I'd like to add your credit as Reported-by: Your Name <your_email@example.com>. You find quite old regression - from 918e824 (released in s20190324). (Update: I mean Reported-by, not Reviewed-by).

@pevik pevik mentioned this issue May 16, 2023
Merged
@pevik pevik added this to the next release milestone May 16, 2023
@cronolio
Copy link
Author

actually you can't check a name and an email is really belong to me.
so nickname is enough. thank you.

@pevik
Copy link
Contributor

pevik commented May 17, 2023

We follow the Linux kernel policy, which expect real name (I'd be ok with the nickname) and real email:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

But sure, you don't have to provide it.

@cronolio
Copy link
Author

i didn't find there anything about real name (at least for reported-by case), so please be careful about what you asking peoples here in next time. and as i told nickname is enough to me. thanks.

@pevik pevik reopened this May 17, 2023
@pevik
Copy link
Contributor

pevik commented May 17, 2023

I keep it open until I merge the fix.

@pevik pevik closed this as completed in 2a63b94 May 17, 2023
@pevik
Copy link
Contributor

pevik commented Jan 16, 2024

@cronolio FYI #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pevik pevik

Labels
bug
Projects
None yet
Milestone
20231222
Development

Successfully merging a pull request may close this issue.

ping: Fix overflow on negative -i pevik/iputils
2 participants
@pevik @cronolio