ping: Restore -i0
#519
Closed
ping: Restore -i0
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iputils/maintainers Could you please have look? I probably release this week to get the regression fixed quickly. |
Closed
pevik
added a commit
to openSUSE/kernel-qe
that referenced
this pull request
Jan 16, 2024
iputils/iputils#519 Signed-off-by: Petr Vorel <pvorel@suse.cz>
|
LGTM, |
-i 0 has been supported for a long time, restore it back. There is no point to force user to set very minimal value to emulate 0. Found by LTP tests (nft01.sh, iptables01.sh) which use it. Fixes: 2a63b94 ("ping: Fix overflow on negative -i") Closes: iputils#519 Reviewed-by: David Heidelberg <david@ixit.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-i 0has been supported for a long time, restore it back. There is no point to force user to set very minimal value to emulate 0.Found by LTP tests (nft01.sh, iptables01.sh) which use it.
Fixes: 2a63b94 ("ping: Fix overflow on negative -i")