Fix build on MUSL #111
Merged
Fix build on MUSL #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase a top of latest IDN2 changes! Thank you 👍 |
Whissi
force-pushed
the
fix-build-on-musl
branch
from
58ed671
to
5b160bb
Compare
|
Rebased like requested, but see issue #117 first. Looks like there's a general problem on musl with idn (not just with idn2, previous version shows same problem). |
|
ya, this patch is required if using IDN on musl, but also causes runtime failures. |
|
@prometheanfire can you be more specific about runtime failures on MUSL? Thanks |
|
@Whissi would be better to ask. |
|
Not really: A Gentoo user replied that MUSL still had problems and this fix was required to address the problem. |
Add missing AI_IDN and NI_IDN declarations. Bug: https://bugs.gentoo.org/503914 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
Whissi
force-pushed
the
fix-build-on-musl
branch
from
5b160bb
to
5007d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing AI_IDN and NI_IDN declarations.
Bug: https://bugs.gentoo.org/503914