ping: use struct timespec to measure time #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerolasa
force-pushed
the
ping-timespec
branch
from
82c7838
to
434573b
Compare
Closed
kerolasa
force-pushed
the
ping-timespec
branch
from
434573b
to
d5b5930
Compare
|
This pull request introduces 4 alerts when merging d5b5930 into 4fd276c - view on LGTM.com new alerts:
|
kerolasa
force-pushed
the
ping-timespec
branch
from
d5b5930
to
59ea5ac
Compare
|
This pull request introduces 3 alerts when merging 59ea5ac into 4fd276c - view on LGTM.com new alerts:
|
Use the struct timespec to measure how much is the time, and various related intervals. Aim of this change is to be exact how time calculation happen, so that it as easy as possible to understand what happens with them. The exponentially weighted moving average changed slightly while writing this change. Earlier implementation was so hard to follow that after this change maths may have changed, but even if they did at least now one should be able to understand the equation - and fix if needed. Notice that there is a need for follow up to remove 'next' millisecond int variable in pinger() and schedule_exit(). That change will be complicated enough to be separate commit. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kerolasa
force-pushed
the
ping-timespec
branch
from
59ea5ac
to
cf0de0a
Compare
|
This pull request introduces 3 alerts when merging cf0de0a into 78e3d25 - view on LGTM.com new alerts:
|
pevik
requested changes
Nov 29, 2020
| @@ -1372,7 +1377,7 @@ int ping4_receive_error_msg(struct ping_rts *rts, socket_st *sock) | |||
| if (rts->opt_flood) { | |||
| write_stdout("\bE", 2); | |||
| } else { | |||
| print_timestamp(rts); | |||
| print_timestamp("[", rts, "]"); | |||
There was a problem hiding this comment.
Does not this change output? Not aware of [ ... ].
There was a problem hiding this comment.
OK, looking you moved [ from print_timestamp(). Could you keep it there? Because than the formatting is duplicated on both places (ping IPv4 and IPv6), i.e. wrong direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the struct timespec to measure how much is the time, and various related
intervals. Aim of this change is to be exact how time calculation happen,
so that it as easy as possible to understand what happens with them.
The exponentially weighted moving average changed slightly while writing
this change. Earlier implementation was so hard to follow that after this
change maths may have changed, but even if they did at least now one should
be able to understand the equation - and fix if needed.
Notice that there is a need for follow up to remove 'next' millisecond int
variable in pinger() and schedule_exit(). That change will be complicated
enough to be separate commit.
p.s. This commit is build on top of #225 Depending on what happens in that
pull request rebase, and rework may be needed. That in mind look only the
last commit within context of this pull request.