Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for first example application with various fixes and changes. #235

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

  • a new flag around websocket notifications
  • rewrite worker/scheduler interaction to make sure db/libp2p is not used upon initial workflow start (happens via spawn in the bg)
  • boxed_local -> boxed and rust compiler bugs!!!!
  • a local-only name option for workflows (not shared via workflow::Info over the network)
  • remove backoff variations, focusing in on exponential (note: may eventually move off tryhard, we'll see)
  • starter examples dir/space

- a new flag around websocket notifications
- rewrite worker/scheduler interaction to make sure db/libp2p is not used upon initial workflow start (happens via spawn in the bg)
- boxed_local -> boxed and rust compiler bugs!!!!
- a local-only name option for workflows (not shared via workflow::Info over the network)
- remove backoff variations, focusing in on exponential (note: may eventually move off tryhard, we'll see)
- starter examples dir/space
- fetch updates
@zeeshanlakhani zeeshanlakhani changed the title Prep for first example application by providing: Prep for first example application with various fixes and changes. Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #235 (89dd370) into main (cee37d4) will decrease coverage by 0.36%.
The diff coverage is 75.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   75.56%   75.20%   -0.36%     
==========================================
  Files          64       65       +1     
  Lines        6004     6107     +103     
==========================================
+ Hits         4537     4593      +56     
- Misses       1467     1514      +47     
Files Changed Coverage Δ
homestar-runtime/src/event_handler/event.rs 15.50% <0.00%> (-0.99%) ⬇️
homestar-runtime/src/network/ipfs.rs 16.66% <0.00%> (ø)
homestar-runtime/src/runner/file.rs 95.31% <ø> (ø)
homestar-runtime/src/runner/response.rs 57.69% <0.00%> (-6.14%) ⬇️
homestar-runtime/src/tasks.rs 100.00% <ø> (ø)
homestar-runtime/src/workflow/settings.rs 90.90% <ø> (+6.29%) ⬆️
homestar-wasm/src/wasmtime/world.rs 87.15% <ø> (ø)
homestar-runtime/src/network/ws.rs 46.71% <35.29%> (-0.95%) ⬇️
homestar-runtime/src/network/rpc.rs 80.19% <66.66%> (+0.19%) ⬆️
homestar-runtime/src/workflow/info.rs 76.27% <71.79%> (+1.18%) ⬆️
... and 14 more

... and 1 file with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit 63c23aa into main Aug 11, 2023
22 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/example-prep branch August 11, 2023 13:59
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant