refactor: Example application with image processing workflow #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 73.07% 72.75% -0.32%
==========================================
Files 65 67 +2
Lines 6313 6702 +389
==========================================
+ Hits 4613 4876 +263
- Misses 1700 1826 +126
|
zeeshanlakhani
force-pushed
the
zl/relay-example
branch
3 times, most recently
from
001829d
to
fe2cd2f
Compare
|
@bgins is looking at a warning and a fix to activeworkflowstate for ordering of workflow plays. |
bgins
approved these changes
Aug 28, 2023
zeeshanlakhani
force-pushed
the
zl/relay-example
branch
2 times, most recently
from
ba96753
to
da11985
Compare
Includes: - removal of libp2p record checks on scheduler (leaves it to worker) - update across the board toward async channels - resource map now includes content over the network as part of fetching - new fetch module - better use of channels to spread out work between internal and swarm events - websocket-relay app documentation and more - no fmt generated files on nightly
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
# Description This PR implements the following changes: - [x] Only render nodes when previous task has completed - [x] Remove task out-of-order error case - [x] Disable a workflow play button when the other workflow is active - [x] Prevent multiple runs of a workflow when it is active (spinner that replaces play button is not clickable) - [x] Rename `task.active` to `task.selected` to better indicate that this is UI state - [x] Remove receipt and instruction CID from completed task dropdown We had an issue where Firefox would receive receipts over the Websocket channel nearly simultaneously which resulted in out-of-order errors. This PR fixes that by delaying the rendering of nodes until each previous task has completed and removing the error case. ## Type of change - [x] Bug fix (non-breaking change that fixes an issue) - [x] Refactor ## Test plan (required) The play button should be disabled when the other workflow is running. The button should not handle click events when in a spinner state. Test in Firefox. No errors should be present and workflows should run and render as expected.
zeeshanlakhani
force-pushed
the
zl/relay-example
branch
from
6471c7b
to
5f16416
Compare
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Closes #246.