Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fragmented TLS handshake records #930

Merged
merged 2 commits into from Mar 30, 2023
Merged

Support fragmented TLS handshake records #930

merged 2 commits into from Mar 30, 2023

Conversation

mcb30
Copy link
Member

@mcb30 mcb30 commented Mar 30, 2023

No description provided.

Prepare for the possibility that a record handler may choose not to
consume the entire record by passing the I/O buffer and requiring the
handler to mark consumed data using iob_pull().

Signed-off-by: Michael Brown <mcb30@ipxe.org>
Originally-implemented-by: Christopher Schenk <christopher@cschenk.net>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
@mcb30 mcb30 merged commit 1d1cf74 into master Mar 30, 2023
4 checks passed
@mcb30 mcb30 deleted the tlsfrag3 branch March 30, 2023 22:57
@vielmetti
Copy link

nice!

nshalman added a commit to nshalman/ipxedust that referenced this pull request Mar 31, 2023
Includes ipxe/ipxe#930 which replaced ipxe/ipxe#116
which provides support for fragmented TLS handshakes
making iPXE able to handle larger TLS certificate
chains and thus less picky about TLS certificates
in general.

Signed-off-by: Nahum Shalman <nshalman@equinix.com>
mergify bot added a commit to tinkerbell/ipxedust that referenced this pull request Mar 31, 2023
## Description

Includes ipxe/ipxe#930 which replaced ipxe/ipxe#116 which provides support for fragmented TLS handshakes making iPXE able to handle larger TLS certificate
chains and thus less picky about TLS certificates
in general.

## Why is this needed

See all the tales of woe in ipxe/ipxe#116

Fixes: #53

## How Has This Been Tested?

- [ ] Needs testing to confirm

## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants