Message hook in display publisher #115
Conversation
|
pinging @minrk @jasongrout |
| @@ -70,6 +78,15 @@ def _flush_streams(self): | |||
| sys.stdout.flush() | |||
| sys.stderr.flush() | |||
|
|
|||
| @default('thread_local') | |||
There was a problem hiding this comment.
Since I think this is the first PR that uses the traitlets 4.1 API, you may want to bump the version requirement in setup.py.
There was a problem hiding this comment.
Master is already at 4.2 -
https://github.com/ipython/ipywidgets/blob/bb5092be3c0e75a12293472584a218d9a217c935/setup.py#L108
so i'll just merge on that.
Thanks!
|
Nice start! |
dwillmer
changed the title
|
@minrk @jasongrout now has comprehensive tests over the new hook functionality - your call on whether we merge and iterate or carry on. |
| ------- | ||
| None | ||
|
|
||
| The DisplayHook objects must return a message from |
There was a problem hiding this comment.
I don't think these are DisplayHook objects since DisplayHook is called on objects, not messages. I think it's any callable with:
def hook(message) => message or None
|
Awesome, thanks @dwillmer! I made one comment in-line about DisplayHook, but I think we can merge and move on shortly. |
|
@minrk - Fixed, thanks! |
|
Thanks! |
Similar to ipython#115 but for stdout/stderr This can be useful for a thread to redirect stdout/stderr to a file, while other threads can still write to stdout/stderr.
This is the initial work for #113.