Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pytest-asyncio and update ruff config #1209

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073 blink1073 merged commit c6d5ad6 into ipython:main Feb 10, 2024
32 checks passed
@blink1073 blink1073 deleted the dev-cleanup branch February 10, 2024 18:56
from types import FunctionType

# This registers a hook when it's imported
from ipyparallel.serialize import codeutil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this "dead code" side-effect is showing up here:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=885003&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=6119ccbe-9301-594f-7c27-f792b80a7fcc&l=1235

_______________________________ test_no_closure _______________________________

    def test_no_closure():
        @interactive
        def foo():
            a = 5
            return a
    
>       pfoo = dumps(foo)

tests\test_pickleutil.py:28: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

obj = <function test_no_closure.<locals>.foo at 0x0000018BD7A07A60>

    def dumps(obj):
>       return pickle.dumps(can(obj))
E       TypeError: cannot pickle code objects


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants