Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error accessing sys.stdout/sys.stderr when those are None #1247

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fixed error accessing sys.stdout/sys.stderr when those are None #1247

merged 1 commit into from
Jul 1, 2024

Conversation

gregory-shklover
Copy link
Contributor

Fix for issue reported in #1119 (sys.stdout/sys.stderr could be None on Windows, when running in GUI mode)

@gregory-shklover gregory-shklover mentioned this pull request Jun 10, 2024
Open
@gregory-shklover
Copy link
Contributor Author

Hi. Any updates on this pull request?

blink1073
blink1073 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 added the bug label Jul 1, 2024
@blink1073 blink1073 merged commit eb10a0d into ipython:main Jul 1, 2024
16 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregory-shklover @blink1073