Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Depends on #445] PR: Create _wait_input_request_reply method #439

Closed
wants to merge 8 commits into from

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Sep 19, 2019

Move the code waiting for an input request reply to a method to make it easier to change this behaviour in a subclass.

@ccordoba12 ccordoba12 mentioned this pull request Oct 4, 2019
@impact27 impact27 changed the title PR: Create _wait_input_request_reply method [Waiting depencency merge] PR: Create _wait_input_request_reply method Oct 5, 2019
@impact27 impact27 closed this Oct 5, 2019
@impact27 impact27 reopened this Oct 5, 2019
@impact27 impact27 changed the title [Waiting depencency merge] PR: Create _wait_input_request_reply method [Depends on #445] PR: Create _wait_input_request_reply method Oct 5, 2019
@impact27
Copy link
Contributor Author

impact27 commented Oct 9, 2019

Merged with #438

@impact27 impact27 closed this Oct 9, 2019
@Carreau Carreau added this to the no action milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants