-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Disable AppNap #441
PR: Disable AppNap #441
Conversation
This could be done only at the event loops level and not for the entire application. At least that's how it was done in old IPython versions: |
I disagree, the problem here is not limited to the back ends. If the user creates a gui app (qt5 / cocoa/ ...), macos will reclassify the kernel as a GUI application. Therefore, If the kernel (which is not a GUI application intrinsically) shows any window at any point, then macos will start to slow it down. Therefore AppNap should not apply to ipykernel. (As AppNap uses window usage as a way to know if the app is used, which is not at all a good indicator in the case of ipykernel.) |
I am not sure what the error is. I see the error intermittently in spyder-kernels tests as well. |
Retriggering the tests |
I am sorry that this makes it hard for you to review. It is my fault for merging the PRs before #445 was ready. I will mark all the PR that depends on another PR as [Waiting depencency merge] so you know that they must not be reviewed before the dependent PR is merged. |
c933f24
to
57cdd0f
Compare
The reason why I need to merge #445in the other PR is that AppVeyor gets stuck if #445 is not merged, so instead of having test suceeding in 10 min, there is failing tests in 3h. |
Even if there you haven't run |
I was able to trigger the problem purely with pyqt5 |
|
Ok, if that's the case then this should be merged as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27 for finding the cause of this very annoying bug!
@blink1073, I think this one is ready.
Thanks! |
solves ipython/ipython#11602
This is caused by AppNap: https://developer.apple.com/library/archive/documentation/Performance/Conceptual/power_efficiency_guidelines_osx/AppNap.html
This can be desactivated by https://pypi.org/project/appnope/