Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter-packaging to 0.10.6 #586

Merged
merged 1 commit into from Sep 28, 2021

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Sep 14, 2021

The import of bdist_wheel is optional:

ipyparallel/setupbase.py

Lines 46 to 49 in da60bff

try:
from wheel.bdist_wheel import bdist_wheel
except ImportError: # pragma: no cover
bdist_wheel = None

Just like the use if it is None protected here:

ipyparallel/setupbase.py

Lines 577 to 578 in da60bff

if bdist_wheel:
cmdclass['bdist_wheel'] = wrapper(bdist_wheel, strict=True)

The use here must be None protected too:

_make_wrapper(bdist_wheel, pre_dist, post_dist)

@minrk
Copy link
Member

minrk commented Sep 14, 2021

setupbase.py is vendored from jupyter-packaging, and shouldn't have any patches not already accepted upstream. I'd recommend submitting this patch upstream, though, since I think it's still correct. We can update here once it's been accepted there.

That said, bdist_wheel is not optional, and is explicitly required in a way that it should be assumed to be available prior to running setup.py. If you've run into this, it probably means something is using outdated build tools (i.e. doesn't support PEP 518). Can I ask how you encountered it?

@ellert
Copy link
Contributor Author

ellert commented Sep 28, 2021

The change was merged upstream.
I have updated the PR to import the updated version.

@minrk minrk changed the title The import of bdist_wheel is optional, must check for None before using it Update jupyter-packaging to 0.10.6 Sep 28, 2021
@minrk minrk merged commit 8a34b35 into ipython:main Sep 28, 2021
@minrk
Copy link
Member

minrk commented Sep 28, 2021

Thanks!

@ellert ellert deleted the bdist-wheel-is-optional branch September 28, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants