Skip to content

Commit

Permalink
Merge pull request #13350 from Kojoley/remove-parso-and-jedi-xfails
Browse files Browse the repository at this point in the history
Remove parso and jedi xfails
  • Loading branch information
Carreau committed Dec 1, 2021
2 parents e343cd4 + cc76a77 commit 341d813
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions IPython/core/tests/test_completer.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@
_deduplicate_completions,
)

if sys.version_info >= (3, 10):
import jedi
from pkg_resources import parse_version

# Requires https://github.com/davidhalter/jedi/pull/1795
jedi_issue = parse_version(jedi.__version__) <= parse_version("0.18.0")
else:
jedi_issue = False

# -----------------------------------------------------------------------------
# Test functions
# -----------------------------------------------------------------------------
Expand Down Expand Up @@ -210,11 +201,6 @@ def _ipython_key_completions_(self):
return list(self.things)


@pytest.mark.xfail(
sys.version_info >= (3, 11),
reason="parso does not support 3.11 yet",
raises=NotImplementedError,
)
class TestCompleter(unittest.TestCase):
def setUp(self):
"""
Expand Down Expand Up @@ -435,8 +421,6 @@ def test_all_completions_dups(self):
matches = c.all_completions("TestCl")
assert matches == ['TestClass'], jedi_status
matches = c.all_completions("TestClass.")
if jedi_status and jedi_issue:
continue
assert len(matches) > 2, jedi_status
matches = c.all_completions("TestClass.a")
assert matches == ['TestClass.a', 'TestClass.a1'], jedi_status
Expand Down Expand Up @@ -491,7 +475,6 @@ def test_completion_have_signature(self):
"encoding" in c.signature
), "Signature of function was not found by completer"

@pytest.mark.xfail(jedi_issue, reason="Known failure on jedi<=0.18.0")
def test_deduplicate_completions(self):
"""
Test that completions are correctly deduplicated (even if ranges are not the same)
Expand Down

0 comments on commit 341d813

Please sign in to comment.